Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1511 error count #1527

Closed
wants to merge 11 commits into from
Closed

1511 error count #1527

wants to merge 11 commits into from

Conversation

scottqueen-bixal
Copy link
Collaborator

PR Summary

This works to refactor or error handling to support reactive field count on errors

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
  • npm run start
  • navigate to first step of the form, without entering values click "continue"
  • ensure an error is thrown
  • ensure the alert banner is focused
  • ensure the number of errors indicated in the alert is equal to the number of inputs/selects that have errors
  • ensure the fields with errors have red borders around them

expected:
Screenshot 2024-07-01 at 10 20 59 PM

  • begin to resolve errors
  • ensure that resolving an error resolves its css notification
  • ensure that resolving an error updates the count in the alert

expected:
Screenshot 2024-07-01 at 10 21 16 PM

  • without resolving all errors CLICK "continue" button again
  • ensure that you can not progress forward
  • ensure the alert banner is focused
  • ensure that when all errors are resolved, the alert banner is not displayed and user can progress forward

@scottqueen-bixal scottqueen-bixal self-assigned this Jul 2, 2024
@scottqueen-bixal scottqueen-bixal requested review from nehemiah-abuga and removed request for gchi25 July 8, 2024 19:34
@scottqueen-bixal
Copy link
Collaborator Author

closing in favor of #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include error count in alert
1 participant