[#155000779] fix time-based searching for collections #47
Conversation
| i14y_params[:query] = search.query | ||
| i14y_params.merge! extract_current_search_filter_params(search) | ||
| i14y_params.merge! extra_params | ||
| search_path i14y_params | ||
| url_for i14y_params |
There was a problem hiding this comment.
Riiiiight? You and me both.
There was a problem hiding this comment.
@viclim check out this clever solution to the /search and /search/docs context problem.
There was a problem hiding this comment.
@viclim ,thanks for the work you did on this story. I didn't actually mean to steal it, but in the process of poking the code to determine how it should work, I figured out how it could work.
There was a problem hiding this comment.
@nickmarden , the return value is just the path, i.e.:
/search/docs?affiliate=764544198&query=test+query&dc=1&sort_by=date&tbs=m
|
@nickmarden , FYI, I'm doing some final local testing before I assign this (to you...) for official review. I like to open unassigned PRs early to get feedback from Code Climate. |
| fixtures :affiliates, :i14y_drawers, :i14y_memberships | ||
| let(:affiliate) { affiliates(:power_affiliate) } | ||
|
|
||
| describe '#path_for_filterable_search' do | ||
| describe '#path_for_filterable_search', type: :request do |
There was a problem hiding this comment.
@nickmarden , it feels a little dirty to make this an integration test, but I wasn't able to find a way to stub the current path used by the url_for method (I barked up a number of trees before finding this solution). If you have such a way, I'm all ears.
|
@MothOnMars addresses three issues that I was concerned about:
Based on all of that, LGTM 👍 |
No description provided.