-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/guma/curve split extension methods #247
Dev/guma/curve split extension methods #247
Conversation
…it-extension-methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks ok, if we want to clean it a bit more before merging that will be perfect
@@ -26,7 +26,7 @@ public static NurbsSurface[] Split(this NurbsSurface surface, double parameter, | |||
{ | |||
throw new ArgumentNullException(nameof(surface)); | |||
} | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces can be removed
{ | ||
return false; | ||
} | ||
|
||
if (Knots.Count != other.Knots.Count) | ||
if (!Knots.SequenceEqual(other.Knots)) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove curly braces if there is only one line of code?
What type of PR is this? (check all applicable)
Description
Adds extension methods to ICurve: SubCurve and SplitAt with multiple parameters.
Related Tickets & Documents
Closes #226
Added tests?
Added to documentation?