Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change knot domain. #327

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Change knot domain. #327

merged 2 commits into from
Sep 3, 2021

Conversation

sonomirco
Copy link
Collaborator

Refactor some comments.

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR updated the KnotsVector Domain property to a method.

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco
Change knot domain.
48bf47a 
Refactor some comments.
@sonomirco sonomirco added the refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. label Sep 3, 2021
@sonomirco sonomirco self-assigned this Sep 3, 2021
@cesarecaoduro cesarecaoduro merged commit 03a50b5 into develop Sep 3, 2021
@sonomirco sonomirco deleted the dev/mibi/knot-domain branch September 9, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3ssy d3ssy Awaiting requested review from d3ssy

@cesarecaoduro cesarecaoduro Awaiting requested review from cesarecaoduro

Assignees

@sonomirco sonomirco

Labels
refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonomirco @cesarecaoduro