Add null check and missing texture for covered cable icons #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
approved these changes
Apr 30, 2024
|
This is an insufficient fix. We have seen it returning null in other getXXXTexture() as well. |
58 tasks
Dream-Master
pushed a commit
that referenced
this pull request
May 3, 2024
(cherry picked from commit dcb0fe8)
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat fixes GTNewHorizons/GT-New-Horizons-Modpack#16075. This doesn't sort out the underlying issue, but it does add some safety to use a missing texture when it happens rather than crashing by returning a null texture.
With this fix, the behavior should be that when it occurs, fluix colored covered cables will render with a missing texture instead of their normal one, though this should only last for the time that it occurred, so in most any scenario wouldn't even be noticeable.
The underlying issue still needs investigated, but this at least makes it a bit safer by not causing a crash.