Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring of Config Files #2

Merged
merged 2 commits into from Jul 30, 2023
Merged

Fix restoring of Config Files #2

merged 2 commits into from Jul 30, 2023

Conversation

glowredman
Copy link
Member

Previously, if the ./config/modpack-update file was shipped with a pack, it wouldn't have been deleted. This would've triggered the restoreLocalConfig() method each time instead of only once after the update and backupLocalConfig() every following start. The code responsible for this was commented out. I uncommented it and tested it (using Technic Solder) and couldn't find any issues.

Allows GTNewHorizons/GT-New-Horizons-Modpack#13971 to work.

Other improvements:

  • Made command responses translatable
  • Replaced java.io.File#delete() with java.nio.Files#delete(java.nio.Path) in a try-catch-block to be able to log the reason should the deletion fail.
  • Fixed /defaultconfigs createUpdateFile command
  • Updated buildscript

@glowredman glowredman requested review from a team July 21, 2023 13:15
@Dream-Master Dream-Master merged commit 61a1986 into master Jul 30, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix-restore branch August 2, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants