Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config entries for Farming Station particles #162

Conversation

socolio
Copy link

@socolio socolio commented May 8, 2024

Nobody cares about these particles. But it can be pretty laggy with fast/large tree farms.

  • decrease number of Farming Station particles (scaled with client setting)
  • decrease range of Farming Station particles
  • add max range of Farming Station particles to config

@boubou19
Copy link
Member

boubou19 commented May 8, 2024

seems like it should be adressed via either a change in EIO to make the particles non laggy, or adressed in angelica. Also pls make it so the default stays the same as it was before. Config will exist thanks to this PR, so anyone will be able to reduce the particles if they like.

Copy link

@TimeConqueror TimeConqueror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TimeConqueror
Copy link

TimeConqueror commented May 8, 2024

seems like it should be adressed via either a change in EIO to make the particles non laggy, or adressed in angelica. Also pls make it so the default stays the same as it was before. Config will exist thanks to this PR, so anyone will be able to reduce the particles if they like.

Why does it need to look the same as before? And as for Angelica, it would be worse to make it there I think, because some of users still use Optifine, including me

@boubou19
Copy link
Member

boubou19 commented May 8, 2024

Because cosmetic PRs always are upsetting people, so it's preferable to opt-in the changes than to opt-out the default settings.

@boubou19
Copy link
Member

boubou19 commented May 8, 2024

And as for Angelica, it would be worse to make it there I think, because some of users still use Optifine, including me

I was saying this in case the laggy code is made in base minecraft. Also optifine is officially unsupported, in favor of Angelica, so if players want to remove angelica that's fine, but done at their own risk.

@socolio
Copy link
Author

socolio commented May 8, 2024

seems like it should be adressed via either a change in EIO to make the particles non laggy, or adressed in angelica. Also pls make it so the default stays the same as it was before. Config will exist thanks to this PR, so anyone will be able to reduce the particles if they like.

Now config uses original values as defaults

@socolio socolio changed the title Decrease number of Farming Station particles Add config entries for Farming Station particles May 8, 2024
@Dream-Master Dream-Master merged commit bd47a39 into GTNewHorizons:master May 8, 2024
1 check passed
Dream-Master pushed a commit that referenced this pull request May 19, 2024
* Decrease number of Farming Station particles

* Set default values for range & number of particles to original

(cherry picked from commit bd47a39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants