Cleanup #76
Merged
Cleanup #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlhlm
reviewed
Jun 5, 2023
src/main/java/micdoodle8/mods/galacticraft/api/transmission/tile/ITransmitter.java
Show resolved
Hide resolved
wlhlm
approved these changes
Jun 5, 2023
eigenraven
reviewed
Jun 5, 2023
| @@ -256,8 +256,8 @@ public void onUpdate() { | |||
| final List<?> var15 = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, box); | |||
|
|
|||
| if (var15 != null && !var15.isEmpty()) { | |||
| for (int var52 = 0; var52 < var15.size(); ++var52) { | |||
| final Entity var17 = (Entity) var15.get(var52); | |||
| for (Object element : var15) { | |||
There was a problem hiding this comment.
This can now be Entity if you fix the generic type above
| @@ -93,8 +93,8 @@ public void onUpdate() { | |||
| .getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.expand(1.0D, 0.5D, 1.0D)); | |||
|
|
|||
| if (var3 != null) { | |||
| for (int var4 = 0; var4 < var3.size(); ++var4) { | |||
| final Entity var5 = (Entity) var3.get(var4); | |||
| for (Object element : var3) { | |||
| @@ -118,8 +118,8 @@ public void onUpdate() { | |||
| .getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.expand(1.0D, 0.5D, 1.0D)); | |||
|
|
|||
| if (var3 != null) { | |||
| for (int var4 = 0; var4 < var3.size(); ++var4) { | |||
| final Entity var5 = (Entity) var3.get(var4); | |||
| for (Object element : var3) { | |||
|
|
||
| if (e instanceof EntityTieredRocket) { | ||
| final EntityTieredRocket ship = (EntityTieredRocket) e; | ||
| for (Object element : l) { |
|
|
||
| if (e instanceof EntityTieredRocket) { | ||
| final EntityTieredRocket ship = (EntityTieredRocket) e; | ||
| for (Object element : l) { |
glowredman
added a commit
that referenced
this pull request
Jun 11, 2023
See @eigenraven's review of #76
Merged
glowredman
added a commit
that referenced
this pull request
Jun 12, 2023
* Fix oversights of last PR See @eigenraven's review of #76 * Update dependencies * Rework rocket fuel API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/gchelpchat output via code and not by serializing JSONBlockCavernousVine#onEntityCollidedWithBlock@APIannotations