Add pollution tooltips #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
force-pushed
the
pollution_tooltip
branch
from
5196492
to
6ca2099
Compare
|
Fixed formatting with |
tytan652
force-pushed
the
pollution_tooltip
branch
from
6ca2099
to
27ab7ea
Compare
|
While re-reading my change, I realized that the Tunnel Bore had a tooltip specifying "per firebox" and was using the wrong value (it was like that in ModMixins too). I updated that. |
OneEyeMaker
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Pollution is GT-specific mechanic. So all pollution-related handlers should be loaded only if GT is loaded. And whole mod (because one isn't strictly bound to GT:NH modpack) should work in almost vanilla environment (without requiring additional mods).
Correct me if I'm mistaken.
src/main/java/com/mitchej123/hodgepodge/HodgepodgeEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/HodgepodgeEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/HodgepodgeEventHandler.java
Outdated
Show resolved
Hide resolved
tytan652
force-pushed
the
pollution_tooltip
branch
2 times, most recently
from
8b440f8
to
198f142
Compare
tytan652
force-pushed
the
pollution_tooltip
branch
from
198f142
to
93a4224
Compare
OneEyeMaker
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#12957
Restore pollution tooltips that were previously added through ModMixins.