Update EntityLocomotiveSteamMagic.java #47
Conversation
Fixed Thaumcraft dependency
|
Okay something is severely broken with this PR if the build and test task fails at this point... I did test the whole thing and it worked, so I guess the test task uses my entire fork instead of this one commit against the main project. Unless there is an easy way to fix this whole Issue I have with my stupid fork, I will not touch this again... |
|
CI failed because a village generated at spawn with a rolling machine (out of sheer luck). rolling machine ask for a RF thing to store power, which is stripped due to RF API somehow not present on classpath. |
|
Wait that means my PREVIOUS PR had Issues because I made that replacement function for the EnergyStorage @optional without making sure there is a fallback... I hate how you can call functions behind an if statement just fine, but as soon as a constructor merely exists that is when the classloader will screw you over... Anyways, it does not have anything to do with this PR luckily... So, to fix that EnergyStorage thing, the function cant be @optional but the Constructor must be called inside of an @optional Method or else the ClassLoader will crash. Guess there needs to be another layer, this time with a trycatch for NoSuchMethodError. |
|
can we add cofh as dependencie or just only for compiling ? |
|
CoFH is only a compile time dependency with this, railcraft can now startup MC all alone by itself once it is merged. The EnergyStorage Class thing is unrelated to this, it was just a coincidence that it got missed in a PREVIOUS pull request. ;) |
i re run action script and it wnet through. so lets merge it :) |
Fixed Thaumcraft dependency, which I did not notice before.
I used the Github Editor this time because nothing I did helped my ability to push to my own motherfucking fork... I did pulls, i did force pulls, I did rebases, i did hard resets, and I still cant commit and push to my own damn fork on github...