Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slaughter / Chopper Tech reborn support #454

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

aria1th
Copy link
Contributor

@aria1th aria1th commented May 21, 2022

allows usage of energy based items
Those items can't extract energy, so it should use SimpleBatteryItem.tryUseEnergy()

Copy link

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SimpleBatteryItem should not be used for items from other mods, it's just a convenience implementation. Please use EnergyStorage.ITEM.

@aria1th
Copy link
Contributor Author

aria1th commented May 21, 2022

Well, it defines getEnergyMaxOutput as 0, so extract() does nothing... (or is there any other reason?)
It has already done with EnergyStorage.ITEM.find(itemStack, ContainerItemContext.withInitial(itemStack))
but it does not return null, it finds : but it can't extract and the only way to decrement its energy is with extract externally

@Technici4n
Copy link

Sounds like it would maybe make more sense to allow these items to extract energy? Instead of bypassing an implementation detail?

@aria1th
Copy link
Contributor Author

aria1th commented May 21, 2022

Yes, I'll try making pr in tech reborn side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants