Bigger changes #37

MaddTheSane · 2015-02-27T07:23:09Z

Let's begin working on having a better OS X version…

The -mmacosx-version-min option will set the MACOSX_DEPLOYMENT_TARGET, as well as properly sets the linker settings.

Store the cases and saves in a static variable. Add support for having cases in the user's directory. Move the storage of the data to within the app's contents.

Currently, we just cast down to the 32-bit integer, as I don't see this project needing 64-bit integers. The only exception to this is the SignatureIsValid function.

Instead, rely on the info.plist file. Add a special macro for help with autorelease pools.

…ring and CFBundleVersion to the version passed to it. Pass GetPropertyListXMLForVersionStringOSX the application's info.plist file. Actually have the project link.

Quiet a warning about an unused function.

(hopefully) Add case opening support for OS X.

Removing unneeded spaces.

GabuEx · 2015-03-20T07:21:35Z

osx/OSXMain.mm

    *pVersionStringLength = 0;

    NSFileManager *defaultManager = [NSFileManager defaultManager];
    NSString *pErrorDesc = nil;
    //TODO: Save the NSString as, say, a static pointer.
-    NSString *pProperyListPath = [defaultManager stringWithFileSystemRepresentation:pPropertyListFilePath.c_str() length: pPropertyListFilePath.size()];
+    NSString *pProperyListPath = [defaultManager


Not your mistake, but while you're here, might as well fix my typo of "propery" (should be "property").

GabuEx · 2015-03-20T07:23:39Z

Hey, sorry for taking so long to get to this - I was super busy when this first went up such that I couldn't have a look at it, and then it kind of fell off my radar. This does look pretty good - I just have a few questions and comments based on my look through it:

If I'm reading the changes to localApplicationSupportDirectory, this changes things such that instead of using NSApplicationSupportDirectory, it uses the resources directory inside the .app? If so, that's awesome; that's pretty much exactly what I was thinking of doing (I was considering doing pretty much this, but then you did it before I dove into that) and was curious if that was the correct thing to do.
I see that you've added an additional cases path in the user directory in addition to the global cases path. I'm wondering why that is - it was my intention to have all cases just be global, as it seems like there's no reason to have cases be per-user, and that could result in there being multiple copies of files several hundred MB in size, which seems suboptimal.
Given that you've switched over to just use Info.plist for the version string retrieval (which makes perfect sense), I don't suppose you were able to test WriteNewVersion() in some way with this change? It seems like things should just work since it explicitly retrieves the current contents, replaces the version number, and then writes out the XML representation of the properties, but I'm just wary of that blowing away something in Info.plist. If not, don't worry about it, but I figured I'd ask.

That's about all that I can think of. Thanks so much for doing all this. :) It's really invaluable to get help from someone who knows OS X so much better than I do (which is to say, at all).

MaddTheSane · 2015-03-20T19:13:47Z

1: Yes. Also, many modern OS X games have their contents within the app bundle.
2: I decided to have cases moved to the user's directory because it's generally a bad practice to modify a bundle's contents, one reason is because someone might not have the right permissions to modify it. This won't be a problem with single-user set-ups, but would have issues if multiple users are set up. There is a folder at /Users/Shared which might be a better option. I'll look into using that instead.
3: I have not tested it, but I do know my NSDictionaries.

Fix a spelling mistake.

GabuEx · 2015-03-24T08:08:09Z

This all sounds good. Wasn't aware that modifying an .app's contents was considered bad practice, though after thinking about that I can see why. If there is a specific shared folder where cases could go, I'm all for that. I'd say this is pretty much ready to be merged once that's done. :)

MaddTheSane added 10 commits February 26, 2015 23:12

Use -mmacosx-version-min=10.6 instead of MACOSX_DEPLOYMENT_TARGET:

bd62858

The -mmacosx-version-min option will set the MACOSX_DEPLOYMENT_TARGET, as well as properly sets the linker settings.

Backport some of my OS X changes:

cc577a4

Store the cases and saves in a static variable. Add support for having cases in the user's directory. Move the storage of the data to within the app's contents.

Spacing changes.

901a67b

Merge branch 'BackToGabu' into biggerChanges

78d85bd

OS X: Bump the version number.

9d118ba

Quiet warnings when setting a 32-bit integer from a 64-bit integer.

58330fc

Currently, we just cast down to the 32-bit integer, as I don't see this project needing 64-bit integers. The only exception to this is the SignatureIsValid function.

Move away from requiring a special file to get our version number.

893f560

Instead, rely on the info.plist file. Add a special macro for help with autorelease pools.

Have GetPropertyListXMLForVersionStringOSX set CFBundleShortVersionSt…

ceb9c0c

…ring and CFBundleVersion to the version passed to it. Pass GetPropertyListXMLForVersionStringOSX the application's info.plist file. Actually have the project link.

Back port the user case preference from Madd's master.

956cc90

Quiet a warning about an unused function.

Add initial drag-and-drop support for cases.

28ba639

(hopefully) Add case opening support for OS X.

MaddTheSane force-pushed the biggerChanges branch from f5acfd8 to 28ba639 Compare February 28, 2015 01:53

Pass string values to the OS X bridge functions by reference.

f677350

Removing unneeded spaces.

GabuEx reviewed Mar 20, 2015
View reviewed changes

Use a more up-to-date API for getting data of a property list.

063c524

Fix a spelling mistake.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigger changes #37

Bigger changes #37

MaddTheSane commented Feb 27, 2015

GabuEx Mar 20, 2015

GabuEx commented Mar 20, 2015

MaddTheSane commented Mar 20, 2015

GabuEx commented Mar 24, 2015

Bigger changes #37

Are you sure you want to change the base?

Bigger changes #37

Conversation

MaddTheSane commented Feb 27, 2015

GabuEx Mar 20, 2015

Choose a reason for hiding this comment

GabuEx commented Mar 20, 2015

MaddTheSane commented Mar 20, 2015

GabuEx commented Mar 24, 2015