Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweak to Merge plug labels #260

Closed
bentoogood opened this issue May 7, 2013 · 5 comments
Closed

Small tweak to Merge plug labels #260

bentoogood opened this issue May 7, 2013 · 5 comments
Labels
image Issues with GafferImage

Comments

@bentoogood
Copy link
Contributor

Having plugs named 'In' and 'In1' on the one node presents some ambiguity.

As there are some constraints requiring us to stick to 'In' for the primary plug, recommendation is to rename plugs to 'In', 'In2', 'In3', etc...

Then in node description, make it clear that 'In'=='B' and 'In2'=='A'

@bentoogood
Copy link
Contributor Author

hmm, not entirely convinced about this given that:
'In2'=='A1'
'In3'=='A2'
'In4'=='A3'

and so on..

@johnhaddon
Copy link
Member

Since we haven't actually used the A/B terminology in Gaffer yet, do we actually want to? Using it, but then having the first input be called B, is actually pretty confusing. Can't we just stick to the naming we have (perhaps moving in1 to in), and document that the operation starts with the leftmost input and progresses by merging in the other inputs from left to right? Maybe we don't need A/B terminology at all?...

@bentoogood
Copy link
Contributor Author

I'm just thinking about how you write out the rule for each merge mode

over = In2 + In ( 1 - In2.alpha )

seems like it could be better

@johnhaddon
Copy link
Member

Maybe we describe it with pictures like on this page?

http://en.wikipedia.org/wiki/Alpha_compositing

@johnhaddon
Copy link
Member

And we could colour the nodule labels with colours matching those in the pictures.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image Issues with GafferImage
Projects
None yet
Development

No branches or pull requests

2 participants