Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement 'SceneInspector' as a hierarchical viewer. #36

Closed
2 of 3 tasks
bentoogood opened this issue Mar 27, 2013 · 3 comments · Fixed by #906
Closed
2 of 3 tasks

Re-implement 'SceneInspector' as a hierarchical viewer. #36

bentoogood opened this issue Mar 27, 2013 · 3 comments · Fixed by #906

Comments

@bentoogood
Copy link
Contributor

To help with display of more complex attributes attached to entities.

Some minor UI improvements to come along with that:

  • two tone row striping should stretch width of view
  • given the importance of 'type' it should be listed immediately after 'Node','Path','Bound'. Type should be cheated for entities that have a transform but no object to say 'type: Group' (?)
  • horizontal anchor for left edge of second column should be quite a bit further right. This is to avoid the columns jumping around when the longest label in the first column changes (due to selection change).
@ghost ghost assigned johnhaddon Mar 27, 2013
@andrewkaufman
Copy link
Contributor

We're a bit confused about this ticket. @johnhaddon do you think we should keep this one? I'm sure the UI of the SceneInspector needs a lot of work, but I'm not sure about the suggestions here and the title.

@andrewkaufman andrewkaufman added this to the IERendering 7 milestone Apr 30, 2014
@andrewkaufman andrewkaufman modified the milestones: SceneInspector and SceneHierarchy, Tag Support Apr 30, 2014
@ldmoser ldmoser modified the milestone: SceneInspector and SceneHierarchy Apr 30, 2014
@johnhaddon
Copy link
Member

Keeping it open makes sense to me - as we add more and more stuff there we will want sections to be collapsible/hierarchical and we will want to take account of each of those items. I think when we first made the ticket we might have been thinking of using a tree view, which I don't think is the right approach now (we need a richer set of widgets for different representations), but since that isn't mentioned explicitly I think we should keep it.

@johnhaddon
Copy link
Member

I've broken out the second item from the todo list into #897, since it's unrelated to the basic restructuring of the UI into a hierarchy.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Jul 11, 2014
- Replaced single giant label with HTML with hierarchy of Widgets. This will allow much more customisation and interaction.
- Made sections collapsible.
- Introduced tabs to separate major sections.
- Added mechanism for registering custom sections.
- Added Diff and TextDiff classes to simplify the display of diffs.
- Added Row class to simplify creation of standard inspector rows.

Fixes GafferHQ#36.
Fixes GafferHQ#821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants