Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointsType node #476

Closed
johnhaddon opened this issue Aug 14, 2013 · 0 comments
Closed

PointsType node #476

johnhaddon opened this issue Aug 14, 2013 · 0 comments
Labels
scene Issues with GafferScene
Milestone
Spring Cleaning

Comments

@johnhaddon
Copy link
Member

This would be similar to the MeshType node, but allow the type of PointsPrimitives to be set (disk, blobby, sprite etc).
@andrewkaufman andrewkaufman modified the milestones: Geometry Instancing, Christmas Grab Bag Dec 2, 2014
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Mar 11, 2015
@johnhaddon
Added PointsType node to GafferScene.
f41b3da 
Since all this really does is modify a constant primitive variable, there is an argument for just using a PrimitiveVariable node to do the work. However :

- Changing the type can change the bound of the primitive, and we must always keep the bound consistent, so a dedicated node is required.
- We may wish to make the type be a specific part of the PointsPrimitive API in future, rather than an ad-hoc primitive variable. Having a dedicated node will allow us to do that without breaking compatibility in Gaffer scripts.

Fixes GafferHQ#476.
@johnhaddon johnhaddon mentioned this issue Mar 11, 2015
Merged
davidsminor pushed a commit to davidsminor/gaffer that referenced this issue Apr 1, 2015
@johnhaddon @davidsminor
Added PointsType node to GafferScene.
2dce5ae 
Since all this really does is modify a constant primitive variable, there is an argument for just using a PrimitiveVariable node to do the work. However :

- Changing the type can change the bound of the primitive, and we must always keep the bound consistent, so a dedicated node is required.
- We may wish to make the type be a specific part of the PointsPrimitive API in future, rather than an ad-hoc primitive variable. Having a dedicated node will allow us to do that without breaking compatibility in Gaffer scripts.

Fixes GafferHQ#476.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scene Issues with GafferScene
Projects
None yet
Milestone
Spring Cleaning
Development

No branches or pull requests
2 participants
@johnhaddon @andrewkaufman