Custom metadata-driven Gadgets in NoduleLayouts #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the internal map to store a mapping from custom gadget name to custom gadget, in addition to the mapping from `Plug *` to Nodule. Nothing is changing about the logic here, we're just preparing the ground for subsequent commits where we'll actually add custom gadgets.
This brings the structure closer to what we do in PlugLayout, making it easier to implement custom gadgets, and raising the possibility of one day allowing nodule layouts to be edited in the NodeEditor (`PlugLayout.layoutOrder()` is the primary interface the UIEditor uses to do its work).
This means we can drop the "is it a ShaderSwitch?" hack, remove another NodeGadget creator, and get one step closer to an entirely metadata-driven UI.
It not longer registers a NodeGadget.
It no longer registers a NodeGadget.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are equivalent to the custom widgets that can be registered with the PlugLayout. This allows us to remove a couple of custom NodeGadget registrations, and also opens up the possibility of allowing drag 'n' drop nodule layout in the UIEditor since internally it uses a similar API to the one in the PlugLayout.
The immediate motivation though is simply to allow PlugAdders to live in the nodule layout so they share the same metadata-driven spacing as the nodules themselves. This will get me one step closer to being able to finally finish up on my BoxIO work.