ColorChooser : Add channel names to sliders #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
approved these changes
Jun 19, 2024
ericmehl
force-pushed
the
colorSliderNames
branch
from
615579b
to
69a8825
Compare
|
I fixed up the change log entry in 69a8825. Should be ready to go now. |
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Jul 16, 2024
This was broken slightly in GafferHQ#5902 when we introduced channel name labels. The text width varies somewhat, causing the numeric widget and sliders to be imperfectly aligned.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Jul 16, 2024
This was broken slightly in GafferHQ#5902 when we introduced channel name labels. The text width varies somewhat, causing the numeric widget and sliders to be imperfectly aligned.
johnhaddon
pushed a commit
to ericmehl/gaffer
that referenced
this pull request
Jul 18, 2024
This was broken slightly in GafferHQ#5902 when we introduced channel name labels. The text width varies somewhat, causing the numeric widget and sliders to be imperfectly aligned.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Jul 18, 2024
This was broken slightly in GafferHQ#5902 when we introduced channel name labels. The text width varies somewhat, causing the numeric widget and sliders to be imperfectly aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does what the title suggests.
The additional
ListContaineris there for the inline color chooser, to increase the spacing between the channel name and theNumericWidgetto match that of plug names / widgets. The initial spacing of 4 seemed a bit crowded, making it 8 for the whole row felt like too much detachment betweenNumericWidgetand the slider.Checklist