Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 在页脚加入环境版本信息 【pull request 示例】 #439

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

Keldos-Li
Copy link
Collaborator

@Keldos-Li Keldos-Li commented Mar 28, 2023

描述

  • 在网页页脚加入python、gradio、项目提交的环境版本信息
  • 去掉gradio原有的“build with gradio”等无关信息(/ω\)

页面截图

before after
image image

相关问题


其实是希望能解决大家提ISSUE时不给出环境版本信息的问题QAQ

补充信息

  • 移植了 stable-diffusion-webui 的部分代码,但其中的run函数似乎是用来判断命令是否能成功运行(否则在输出错误信息)用的。是否可以去除我并不清楚QAQ
  • 不知道直接下载zip安装的用户能否读取到 git 的 commit 信息,以及如果无法读取的显示效果如何
  • 不知道部署在hugging face中会怎么样显示

开发进度

  • 完成代码移植
  • 讨论run函数是否值得保留
  • 测试多个平台的显示效果

另外,这也是一个符合 贡献指南 标准的示例 pull request。

@Keldos-Li Keldos-Li marked this pull request as ready for review March 28, 2023 15:46
@Keldos-Li Keldos-Li marked this pull request as draft March 29, 2023 05:19
@Keldos-Li
Copy link
Collaborator Author

Update:

当没有git信息时显示unkown
image

- 去掉了build with gradio信息(/ω\)
- 借鉴了stable-diffusion-webui
chore: 若无git信息尝试显示文件修改时间

还是换回了unkown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant