Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to export mlflow environment variables in mlflow.yml #31

Closed
Galileo-Galilei opened this issue Jul 21, 2020 · 2 comments · Fixed by #126
Closed

Add possibility to export mlflow environment variables in mlflow.yml #31

Galileo-Galilei opened this issue Jul 21, 2020 · 2 comments · Fixed by #126
Labels
enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen
Projects
Ongoing development
Milestone
Release 0.4.1

Comments

@Galileo-Galilei
Copy link
Owner

This is required in #15 but is a more general need. Interactions with credentials must be designed.
@Galileo-Galilei Galileo-Galilei added enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen labels Jul 22, 2020
@turn1a
Copy link
Contributor

turn1a commented Aug 5, 2020

@Galileo-Galilei what do you mean by exporting MLflow environmental variables in mlflow.yml? Could we keep it consistent with MLflow and Kedro and use .env? It's already loaded by Kedro by default (I use it to configure PYTHONPATH for debugging in VSCode.

@Galileo-Galilei
Copy link
Owner Author

Galileo-Galilei commented Aug 18, 2020 •
edited

Yes, sure. Actually, I am not a big fan (to say the least) of having a proprietary config file so I am totally in favor of reusing what already exists. This issue is left open to keep track to the need to refactor the mlflow.yml file and the associated documentation.

@takikadiri takikadiri mentioned this issue Sep 20, 2020
Closed
@takikadiri takikadiri mentioned this issue Oct 4, 2020
Closed
takikadiri added a commit to takikadiri/kedro-mlflow that referenced this issue Oct 11, 2020
@takikadiri
FIX Galileo-Galilei#66 Galileo-Galilei#64 Galileo-Galilei#54 Galileo-…
d691b96 
…Galilei#30 Galileo-Galilei#31 Galileo-Galilei#72 Galileo-Galilei#29 Galileo-Galilei#62 - context access - kedro 16.5 - hook auto registration
@takikadiri takikadiri mentioned this issue Oct 11, 2020
Closed
6 tasks
@Galileo-Galilei Galileo-Galilei moved this from To do to Planned for next release in Ongoing development Oct 12, 2020
@takikadiri takikadiri mentioned this issue Oct 15, 2020
Merged
6 tasks
@Galileo-Galilei Galileo-Galilei moved this from Planned for next release to To do in Ongoing development Oct 26, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.5.0 milestone Oct 26, 2020
@Galileo-Galilei Galileo-Galilei moved this from To do to Planned for next release in Ongoing development Nov 4, 2020
@Galileo-Galilei Galileo-Galilei moved this from Planned for next release to In progress in Ongoing development Nov 25, 2020
@Galileo-Galilei Galileo-Galilei mentioned this issue Nov 26, 2020
Merged
6 tasks
@Galileo-Galilei Galileo-Galilei moved this from In progress to Pending review in Ongoing development Nov 26, 2020
Ongoing development automation moved this from Pending review to Done Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen
Projects
Ongoing development
  
Done
Milestone
Release 0.4.1
2 participants
@turn1a @Galileo-Galilei