This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
feat: split the badger emissions for the two setts #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i dont have the permissions, but this is ready to review now @GalloDaSballo |
mitche50
reviewed
May 20, 2022
| @@ -83,6 +86,7 @@ contract VotiumBribesProcessor is CowSwapSeller { | |||
| function ragequit(IERC20 token, bool sendToGovernance) external nonReentrant { | |||
| bool timeHasExpired = block.timestamp > lastBribeAction + MAX_MANAGER_IDLE_TIME; | |||
| require(msg.sender == manager || timeHasExpired); | |||
| require(HARVEST_FORWARDER.badger_tree() == BADGER_TREE); | |||
There was a problem hiding this comment.
We should only check this if sendToGovernance is false. If it's true then we just send tokens directly to governance not to the tree
There was a problem hiding this comment.
Agree to run the check after the if, saves 2.2k gas when not-needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check thoroughly, tests are passing but im still learning ;)