Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add misc.bytes_iter and misc.bytes_list #1568

Closed
wants to merge 2 commits into from
Closed

Add misc.bytes_iter and misc.bytes_list #1568

wants to merge 2 commits into from

Conversation

heapcrash
Copy link
Collaborator

Fixes #1532

@heapcrash heapcrash modified the milestones: 4.3.0, Someday Jun 9, 2020
@Arusekk
Copy link
Member

Arusekk commented Jun 9, 2020

In most places we now use an idiom for charcode in bytearray(bytes_object):. WDYT? If we want to introduce compatibility functions, I would prefer adding ones that emulate py3 behavior under py2 (easier to maintain / eventually drop py2 support in some AD 2100), unless this would prove explicitly useful in several places.

Arusekk
Arusekk requested changes Oct 20, 2020
View reviewed changes
Copy link
Member

@Arusekk Arusekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this. We already use bytearray heavily.

pwnlib/util/misc.py
@@ -394,7 +394,7 @@ def register_sizes(regs, in_sizes):
'ch': ['ecx', 'cx', 'ch'],
'cl': ['ecx', 'cx', 'cl'],
'cx': ['ecx', 'cx'],
'dh': ['edx', 'dx', 'dh'],
'dh': ['edx', 'dx', 'dh'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! Ugly accidental whitespace changes

Suggested change
'dh': ['edx', 'dx', 'dh'],
'dh': ['edx', 'dx', 'dh'],

@zachriggle
Copy link
Member

Thanks for digging into this @Arusekk

@heapcrash
Copy link
Collaborator Author

Need to follow up on this one.

@Arusekk
Copy link
Member

Arusekk commented Jul 9, 2023

Pretty sure this is not very useful; closing for now, we can revisit this if needed.

@Arusekk Arusekk closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arusekk Arusekk Arusekk requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Someday
Development

Successfully merging this pull request may close these issues.

Iterating over bytes on Python3
3 participants
@heapcrash @Arusekk @zachriggle