Make gdb.attach work with arrays instead of string concatenation #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in a simpler set of code that is more resilient to issues with quoting and files with spaces in their name.
|
this fixes an issue I've been having for a while with using pwntools' gdb package and my terminal (kitty) because it treats the first argument as a binary location and won't parse it. much appreciated! |
|
I've got a Pull Request that's working towards this already:
#1846
…On Tue, Mar 23, 2021 at 11:38 AM Teddy Heinen ***@***.***> wrote:
this fixes an issue I've been having for a while with using pwntools' gdb
package and my terminal (kitty) because it treats the first argument as a
binary location and won't parse it. much appreciated!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1846 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APYTIFMBK2JWLCOOV5NLTOTTFC7XNANCNFSM4YYTHKSQ>
.
|
Arusekk
reviewed
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a simpler set of code that is more resilient to
issues with quoting and files with spaces in their name.