Remove stack references; cabal is now fully capable for this project. #1098
Conversation
|
Stack support was removed some time ago. Fixes #1097 |
README.md
Outdated
| `stack`, as `cabal new-*` [does not yet support coverage](https://github.com/haskell/cabal/issues/5213). | ||
| Use `scripts/stack-test-coverage.sh` to generate a coverage | ||
| report for all test suites. | ||
| Testing with coverage tracking is done via `cabal test --enable-coverage ...` |
There was a problem hiding this comment.
Make sure to mention to mention the workaround for #884 here.
README.md
Outdated
| Crucible can be built with the `cabal` tool (although it is not compatible with | ||
| the old/v1 cabal version). |
There was a problem hiding this comment.
To be honest, the cabal-v1 commands are old enough by this point that I don't think that they're even worth calling out here. You'd have to go out of your way to try them, since they aren't the default anymore.
There was a problem hiding this comment.
Thanks: that confirms my suspicions on the matter. I've removed the archaic reference.
README.md
Outdated
| stack build | ||
| ``` | ||
| Crucible can be built with the `cabal` tool (although it is not compatible with | ||
| the old/v1 cabal version). | ||
|
|
||
| ``` | ||
| ./scripts/build-sandbox.sh |
There was a problem hiding this comment.
As a side note (not necessarily something that you need to do in this PR), I wonder if this script is even worth having. All it does currently is:
We could just as well inline this into the README instructions. Moreover, I'm not sure how I feel about the --recursive part, since that will likely cause submodules to clone other submodules that aren't necessarily for the crucible build.
There was a problem hiding this comment.
Good catch: I've removed it and the references in an update.
The repository submodule management has been updated and simplified, making this script irrelevant.
No description provided.