crucible-llvm: Add integer-related llvm.vector.reduce.* intrinsics
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring only.
This patch: * Adds the ability to register polymorphic LLVM overrides involving vector types. (Previously, the polymorphic LLVM machinery was able to handle overrides that vary over a single integer type, but they did not handle vector types with varying sizes.) * Adds polymorphic overrides for all of the integer-related `llvm.vector.reduce.*` intrinsics, which work over any vector or integer size. * Adds a `T1177.c` test case to the `crux-llvm` test suite which provides some assurance that the `crucible-llvm` semantics work as expected. Fixes #1177.
kquick
approved these changes
May 9, 2024
| -> NatRepr intSz | ||
| -- ^ The size of the integer type. | ||
| -> LLVMOverride p sym ext | ||
| (EmptyCtx ::> VectorType (BVType intSz)) |
There was a problem hiding this comment.
It may be useful in the future to create a VectorSizedType vecSz (BVType intSz) representation to correlate/constrain the arguments, but I don't think it's worth the impact to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
llvm.vector.reduce.*intrinsics, which work over any vector or integer size.T1177.ctest case to thecrux-llvmtest suite which provides some assurance that thecrucible-llvmsemantics work as expected.Fixes #1177.