crucible-llvm: Skip llvm.experimental.noalias.scope.decl and llvm.dbg.assign
#1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….assign This adds `llvm.experimental.noalias.scope.decl` and `llvm.dbg.assign` to the list of LLVM intrinsics that `crucible-llvm` skips over during simulation. Doing so unlocks more support for recent LLVM versions. It is conceivable that we may want to reason about these intrinsics at a deeper level some day. If so, see: * #1196 (comment) for how this would be done for `llvm.experimental.noalias.scope.decl` * #1204 (comment) for how this would be done for `llvm.dbg.assign` Fixes #1196. Fixes #1204.
kquick
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
llvm.experimental.noalias.scope.declandllvm.dbg.assignto the list of LLVM intrinsics thatcrucible-llvmskips over during simulation. Doing so unlocks more support for recent LLVM versions.It is conceivable that we may want to reason about these intrinsics at a deeper level some day. If so, see:
llvm.experimental.noalias.scope.declintrinsic #1196 (comment) for how this would be done forllvm.experimental.noalias.scope.declcrucible-llvm: Don't crash when simulatingllvm.dbg.assignintrinsic #1204 (comment) for how this would be done forllvm.dbg.assignFixes #1196. Fixes #1204.