Fix DITemplateTypeParameter and DITemplateValueParameter #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and working on a _very_ large C++ program. Fixes GaloisInc#43, text copied from that issue: -------------------------------------------------------- Okay, this particular node has an especially twisted history. 0. [Feb 12, 2015](llvm-mirror/llvm@8921bbc): `MDTemplateTypeParameter` lands. It's fields have type i. `Num` ii. `Maybe PValMd` iii. `MDString` iv. `Maybe PValMd` v. `Maybe PValMd` 1. [Feb 18, 2015](llvm-mirror/llvm@eac950e ): The last field, "scope", was dropped, and the type of the second field was made into a `MDString`. 2. [Apr 23, 2016](llvm-mirror/llvm@de74840): Removal of MDString-based references (see GaloisInc#39). Third field is made into a `DITypeRef`. Interestingly, at no point in this process does the field only have three fields, [as it does in the AST](https://github.com/elliottt/llvm-pretty/blob/de881be8e97bc085150d816d359599d75ad3ac9b/src/Text/LLVM/AST.hs#L1100). The biggest flaw I'm seeing is that the first field of the record _is not a reference_, but it is looked up as if it is one. This is causing the parser to crash, because the reference is not defined.
This is so the bitcode parser can depend on a version with current support for DITemplate(Type|Value)Parameter, see last commit
|
I ran |
|
I created a tag: https://github.com/elliottt/llvm-pretty/releases/tag/llvm-pretty-0.7.7 I probably should've been doing that with each change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and working on a very large C++ program.