Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump cabal version #1861

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[CI] Bump cabal version #1861

merged 2 commits into from
Apr 20, 2023

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Apr 19, 2023

No description provided.

@m-yac m-yac changed the title [Don't Merge] Testing #1856 [CI] Bump cabal version Apr 19, 2023
@RyanGlScott
Copy link
Contributor

RyanGlScott commented Apr 20, 2023

@m-yac, I pushed a follow-up commit which updates the cabal version in a couple of additional places (not doing so was causing the build to fail for unrelated, spurious reasons).

@m-yac
Copy link
Contributor Author

m-yac commented Apr 20, 2023

Well, looks like maybe this works? Should we go ahead and merge?

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to know with certainly if this actually fixes the underlying issue, given that it's possible that this requires certain branches to trigger. Nevertheless, this seems like a strict improvement. Let's merge this and see what the CI for the master branch says.

@m-yac m-yac marked this pull request as ready for review April 20, 2023 21:42
@m-yac m-yac merged commit 5df5615 into master Apr 20, 2023
34 checks passed
@m-yac m-yac deleted the ci-prelude-sawcore branch April 20, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants