Properly extend path condition for llvm_conditional_points_to
#1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
RyanGlScott
added
ready-to-merge
This patch adds a `ReaderT` component to the `OverrideMatcher'` monad transformer, where the reader portions are represented with the new `OverrideEnv'` data type. Currently, the only field of `OverrideEnv'` is `_oeConditionalPred`, which is used to represent a path condition for any assumptions or assertions created in a specification. See `Note [oeConditionalPred]` for a lengthier explanation. While introducing this does require a fair bit of refactoring, this patch in isolation does not change any user-visible behavior. In a subsequent commit, we will leverage `oeConditionalPred` to introduce a fix for #1945.
This leverages the newly introduced `withConditionalPred` function (see the parent commit) to make `llvm_conditional_points_to cond ptr val` properly extend the path condition with `cond` before matching `val` against the value that `ptr` points to. Fixes #1945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ReaderTcomponent to theOverrideMatcher'monad transformer, where the reader portions are represented with the newOverrideEnv'data type. Currently, the only field ofOverrideEnv'is_oeConditionalPred, which is used to represent a path condition for any assumptions or assertions created in a specification. SeeNote [oeConditionalPred]for a lengthier explanation._oeConditionalPredto makellvm_conditional_points_to cond ptr valproperly extend the path condition withcondbefore matchingvalagainst the value thatptrpoints to.Fixes #1945.