Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the github workflow for unit tests #93

Closed
wants to merge 3 commits into from

Conversation

SiddheshKanawade
Copy link

What does this PR do?

  • Add github workflow for unit tests
  • Update the version of graphql_client
  • Add Cargo.lock in gitignore as its recommended to ignore Cargo.lock when it keeps track of libraries. Detailed discussion can be found here

Signed-off by: SiddheshKanawade siddhesh.kanawade@iitgn.ac.in

@SiddheshKanawade
Copy link
Author

@nicolasburtey i have added the workflow for unit tests. Please review the PR and let me know if there is anything else to be done in this

@nicolasburtey nicolasburtey requested review from sandipndev and bodymindarts and removed request for sandipndev March 7, 2023 15:34
@SiddheshKanawade
Copy link
Author

@nicolasburtey @sandipndev @bodymindarts could you please approve the github workflow? I just want to check whether the unit tests are passing or not. In my local system, most of the unit tests are failing as respective user can't be found. Following is the stack trace for the same.

thread 'batch_cant_pay_self' panicked at 'assertion failed: batch.populate_wallet_id().is_ok()', tests/batch.rs:40:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

and below is the query output from this

Err(Username userA doesn't exist)

It seems I need to populate some data in my local system, I have successfully set the Postman for local development using the documentation. I am yet figuring out how to resolve the above issue and add the user to the system, any help is highly appreciated.

System: MacOS M1
Unit test: batch_cant_pay_self

@SiddheshKanawade
Copy link
Author

@nicolasburtey @sandipndev I feel this PR can be merged. So that whenever we do some changes to unit tests, we can check here whether that particular test works fine or not. Implementing/Correcting tests can go as part of different PR.

@sandipndev
Copy link
Member

this PR deletes a lot of important files, actions for testing was added a week back in a different PR.

@sandipndev sandipndev closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants