fix: broken route translation for ln invoices to domain #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routes hints from ln invoices were not being translated to our domain properly and so were returning
undefined
values when converted back to pass into thelightning
library'spayViaPaymentDetails
method.The end result of this bug was that we weren't able to pay any invoices where there were route hints and where the final destination was a private node/channel.
Affected wallets for receiving from us that will now work again: