Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken route translation for ln invoices to domain #855

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Dec 24, 2021

Description

Routes hints from ln invoices were not being translated to our domain properly and so were returning undefined values when converted back to pass into the lightning library's payViaPaymentDetails method.

The end result of this bug was that we weren't able to pay any invoices where there were route hints and where the final destination was a private node/channel.

Affected wallets for receiving from us that will now work again:

@dolcalmi dolcalmi merged commit 1c7c06b into main Dec 24, 2021
@vindard vindard deleted the fix-invoice-route-translation branch December 24, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants