Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not fetching lightning when there is a : in the bip21 #319

Merged

Conversation

nicolasburtey
Copy link
Member

@nicolasburtey nicolasburtey commented Dec 5, 2023

@@ -238,11 +238,24 @@ const getLNParam = (data: string): string | null => {
const getProtocolAndData = (
destination: string,
): { protocol: string; destinationWithoutProtocol: string } => {
// input might start with 'lightning:', 'bitcoin:'
const split = destination.split(":")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the culprit

src/parsing/index.ts Outdated Show resolved Hide resolved
@nicolasburtey nicolasburtey merged commit 9bb28af into main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIP21 invoices should default to lightning first
3 participants