chore: upgrade to kratos v13 #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
force-pushed
the
chore--upgrade-to-kratos-v13
branch
2 times, most recently
from
97e198b
to
966095c
Compare
nicolasburtey
force-pushed
the
chore--upgrade-to-kratos-v13
branch
from
966095c
to
6e64116
Compare
bodymindarts
approved these changes
Apr 24, 2023
|
|
||
| // we expect the phone number to not exist | ||
| if (user instanceof Error) { | ||
| console.log("phone doesn't already exist") |
There was a problem hiding this comment.
Can we send an OTEL event instead of log?
| return | ||
| } | ||
|
|
||
| console.error("phone already exist") |
| return | ||
| } | ||
|
|
||
| // TODO |
There was a problem hiding this comment.
Is this really needed? I don't think we will loose site of the fact that we may want to implement email+pw
| @@ -51,16 +107,18 @@ kratosRouter.post( | |||
|
|
|||
| const userIdChecked = checkedToUserId(userId) | |||
| if (userIdChecked instanceof Error) { | |||
| // TODO: log this error as critical to honeycomb | |||
There was a problem hiding this comment.
Then we should probably do it pre-merge or?
| @@ -83,6 +141,7 @@ kratosRouter.post( | |||
| } | |||
|
|
|||
| if (account instanceof Error) { | |||
| // TODO: log this error as critical to honeycomb | |||
There was a problem hiding this comment.
Then we should do it pre-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.