Implement spans for metrics profiling #1268
Conversation
github-actions
bot
added
A-Core
B-Telemetry
S-Triage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 354 354
Lines 26330 26330
=======================================
Hits 10695 10695
Misses 15635 15635 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::string name(); | ||
|
|
||
| private: | ||
| std::thread::id id; ///< Thread id where span was invoked. |
There was a problem hiding this comment.
invalid case style for private member id
| std::thread::id id; ///< Thread id where span was invoked. | |
| std::thread::id mId; ///< Thread id where span was invoked. |
| } | ||
|
|
||
| SpanManager::Span::Span(const std::string& name, std::size_t level, const std::string& file, std::size_t line) | ||
| : id(std::this_thread::get_id()) |
There was a problem hiding this comment.
invalid case style for private member id
| : id(std::this_thread::get_id()) | |
| : mId(std::this_thread::get_id()) |
| std::string name(); | ||
|
|
||
| private: | ||
| std::thread::id id; ///< Thread id where span was invoked. |
There was a problem hiding this comment.
invalid case style for private member id
| std::thread::id id; ///< Thread id where span was invoked. | |
| std::thread::id mId; ///< Thread id where span was invoked. |
| std::thread::id id; ///< Thread id where span was invoked. | ||
| std::string mName; ///< The name of the scope. | ||
| std::string mFile; ///< The file from where it was invoked. | ||
| std::size_t mLine; ///< The line from where it was invoked. |
There was a problem hiding this comment.
private field mLine is not used
| std::string mFile; ///< The file from where it was invoked. | ||
| std::size_t mLine; ///< The line from where it was invoked. | ||
| std::chrono::time_point<std::chrono::high_resolution_clock> mStart; ///< Start time when constructed. | ||
| int mLevel; |
There was a problem hiding this comment.
private field mLevel is not used
| return state; | ||
| } | ||
|
|
||
| SpanManager::Span::Span(const std::string& name, std::size_t level, const std::string& file, std::size_t line) |
There was a problem hiding this comment.
pass by value and use std::move
|
|
||
| SpanManager::Span::Span(const std::string& name, std::size_t level, const std::string& file, std::size_t line) | ||
| : id(std::this_thread::get_id()) | ||
| , mLevel(level) |
There was a problem hiding this comment.
field mLevel will be initialized after field mName
| , mLevel(level) |
| , mFile(file) | ||
| , mLine(line) | ||
| , mStart(std::chrono::time_point<std::chrono::high_resolution_clock>::clock::now()) | ||
| { |
There was a problem hiding this comment.
field mLevel will be initialized after field mName
| { | |
| , mLevel(level) | |
| { |
|
|
||
| SpanManager::Span::Span(const std::string& name, std::size_t level, const std::string& file, std::size_t line) | ||
| : id(std::this_thread::get_id()) | ||
| , mLevel(level) |
There was a problem hiding this comment.
narrowing conversion from std::size_t (aka unsigned long) to signed type int is implementation-defined
|
|
||
| SpanManager::Span::Span(const std::string& name, std::size_t level, const std::string& file, std::size_t line) | ||
| : id(std::this_thread::get_id()) | ||
| , mLevel(level) |
There was a problem hiding this comment.
implicit conversion loses integer precision: std::size_t (aka unsigned long) to int
| SpanManager::Span::~Span() | ||
| { | ||
| auto now = std::chrono::time_point<std::chrono::high_resolution_clock>::clock::now(); | ||
| std::chrono::duration<double, std::milli> elapsed = now - mStart; |
There was a problem hiding this comment.
Value stored to elapsed during its initialization is never read
| SpanManager::Span::~Span() | ||
| { | ||
| auto now = std::chrono::time_point<std::chrono::high_resolution_clock>::clock::now(); | ||
| std::chrono::duration<double, std::milli> elapsed = now - mStart; |
There was a problem hiding this comment.
unused variable elapsed
Description
See linked issue for proposed implementation, but in short:
telwith metrics, tracing and logging.Checklist