Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Craftopia #3739

Merged
merged 10 commits into from
May 26, 2023
Merged

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 9, 2022

Description

Add Server Craftopia

Fixes #3727

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 linked an issue Jan 9, 2022 that may be closed by this pull request
4 tasks
@h3o66 h3o66 changed the title Merge branch 'release/21.5.0' into develop feat(newserver): Craftopia Jan 9, 2022
@h3o66 h3o66 added this to the v22.1.0 milestone Jan 9, 2022
@h3o66 h3o66 force-pushed the feature/craftopia branch 2 times, most recently from a8a2f26 to 5e4d98b Compare January 10, 2022 17:41
@h3o66
Copy link
Member Author

h3o66 commented Jan 13, 2022

Note: needs to be rebased after #3745

@h3o66 h3o66 modified the milestones: v22.1.0, v22.2.0 Jun 3, 2022
@h3o66 h3o66 force-pushed the feature/craftopia branch 3 times, most recently from da34115 to 2470449 Compare August 24, 2022 16:53
@h3o66 h3o66 marked this pull request as ready for review August 24, 2022 16:57
@h3o66
Copy link
Member Author

h3o66 commented Aug 24, 2022

Should be ready for review now

This commit adds a new function, fn_info_game_ct(), that retrieves configuration file parameters for the game server. The function supports ini files and extracts values for configip, gamemode, maxplayers, port, saveinterval, servername, serverpassword and serverpasswordenabled.
@dgibbs64 dgibbs64 added this to the v23.3.0 milestone May 26, 2023
@dgibbs64 dgibbs64 merged commit 561206c into GameServerManagers:develop May 26, 2023
2 of 3 checks passed
@h3o66 h3o66 deleted the feature/craftopia branch May 28, 2023 22:11
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Craftopia
2 participants