-
-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): move default settings to seperate conf #3745
base: develop
Are you sure you want to change the base?
feat(core): move default settings to seperate conf #3745
Conversation
b24f9ae
to
4bfd09b
Compare
aa1e704
to
3960d3e
Compare
I am happy with the idea. I just need to do testing 👍🏻 |
looks like it needs at first a rebase before testing to match the develop branch |
89e7f60
to
dacc33e
Compare
Rebased. |
c5c0259
to
0df6cfb
Compare
Rebased this again to the latest develop branch and added the 2 new added servers to the PR. |
0df6cfb
to
88bea7a
Compare
f02e53d
to
2257be4
Compare
891ed8f
to
ca184e3
Compare
7a72c04
to
f28a4e5
Compare
Description
Move the notification part to a seperate config and prevent users from making changes there.
Fixes #3741
Type of change
Checklist
PR will not be merged until all steps are complete.
develop
branch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!