Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): move default settings to seperate conf #3745

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 12, 2022

Description

Move the notification part to a seperate config and prevent users from making changes there.

Fixes #3741

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 linked an issue Jan 12, 2022 that may be closed by this pull request
3 tasks
@h3o66 h3o66 force-pushed the feature/notication-config-split branch 2 times, most recently from b24f9ae to 4bfd09b Compare January 12, 2022 21:45
@h3o66 h3o66 added this to the v22.1.0 milestone Jan 12, 2022
@h3o66 h3o66 marked this pull request as ready for review January 12, 2022 21:49
@h3o66 h3o66 requested a review from dgibbs64 January 12, 2022 21:49
@h3o66 h3o66 mentioned this pull request Jan 13, 2022
13 tasks
@h3o66 h3o66 force-pushed the feature/notication-config-split branch 3 times, most recently from aa1e704 to 3960d3e Compare January 19, 2022 22:04
@h3o66 h3o66 changed the title feat(core): move notification settings to seperate config feat(core): move default settings to seperate conf Jan 19, 2022
@dgibbs64
Copy link
Member

I am happy with the idea. I just need to do testing 👍🏻

@h3o66
Copy link
Member Author

h3o66 commented Apr 27, 2022

I am happy with the idea. I just need to do testing 👍🏻

looks like it needs at first a rebase before testing to match the develop branch

@h3o66 h3o66 force-pushed the feature/notication-config-split branch from 89e7f60 to dacc33e Compare May 23, 2022 18:27
@h3o66
Copy link
Member Author

h3o66 commented May 23, 2022

Rebased.
Another idea for this: Maybe we consider to do this the other way around and use the new one as a inital template and only set the variables in the serverconfig what you need.

@h3o66 h3o66 modified the milestones: v22.1.0, v22.2.0 Jun 3, 2022
@h3o66 h3o66 force-pushed the feature/notication-config-split branch from c5c0259 to 0df6cfb Compare August 24, 2022 13:42
@h3o66
Copy link
Member Author

h3o66 commented Aug 24, 2022

Rebased this again to the latest develop branch and added the 2 new added servers to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] split notification config into seperate template
2 participants