Book Binders: 1.20.5 update #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamelessly stolen from MC-100000 |
misode
requested changes
May 8, 2024
gm4_book_binders/data/gm4_book_binders/functions/binder/recipes/bind.mcfunction
Outdated
Show resolved
Hide resolved
gm4_book_binders/data/gm4_book_binders/functions/binder/recipes/check_recipes.mcfunction
Show resolved
Hide resolved
- Prevents duplicate enchant&level page from being absorbed - Updated run from comment that misode pointed out
misode
approved these changes
May 15, 2024
misode
added a commit
that referenced
this pull request
May 28, 2024
* Apply overlays * Update version numbers and pack format for 1.20.5 * Update all tests to 1.20.5 * Temporarily disable player heads plugins * Fix location predicates * Fix nested loot tables * Fix set lore mode field * Fix block/fluid/item predicates * Fix attribute operations * Potion contents item sub predicates * Enchantment item sub predicates * Advancement icons * Sweeping edge rename * Update yellow shulker box loot table * Fix set_nbt loot functions * Fix component issues with last commit - set_custom_data function only accepts stringified snbt - profile properties were incorrectly upgraded - written_book_content component had a typo * Upgrade custom model data substitutions * Fix advancement icon components * More set_nbt fixes * Misc errors * Replace horse jump strength attribute with max_stack_size=1 * Remove lib player heads, update skin cache plugin * Fix item predicate NBT field to sub predicates * Count -> count * scute -> turtle_scute * Fix remaining issues in loot table, recipe, advancements ignoring copy_nbt * Fix attribute operations in commands * Update mecha * Update copy_nbt in better armour stands, boots of ostara, chairs, and crossbow cartridges * Update copy_nbt in arborenda and mountaineering * Metallurgy item validity + update commands * Update item nbt checks in a few places + sunken treasure * Update lib trades, DecorItem -> body_armor_item * Lib trees * A bunch of tag -> components * Fix machine block placing * More tag -> components fixes + re-add b suffix in set_custom_data * Update mecha * Update particle syntax * Display frames + lightning in a bottle * Update to java 21 and 1.20.5-pre1 * Fix int providers no long wrapped in value field * Fix remaining particle commands * Update yellow shulker box loot table * Some balloon animals updates * Update packtest to 1.20.5 * Fix some errors in the tests * Even more tag -> components fixes * Final tag -> components fixes (except combat expanded) * Temporarily disable guidebook copy_nbt functions * Fix some leftover item nbt * biome -> biomes, structure -> structures, potion * Fix some more tests - amplifier:0b is not stored - add skyaccess to some tests - replace ambient_entity_effect * Combat expanded tag -> components fixes * Replace CMD in item components * Fix particles in area effect clouds * Replace some item_used_on_block with default_block_use * Fix a few more tests * Fix auto crafting item tag predicates * Random fixes (enchantment checks, phantom scarecrows, animi) * Fix area effect cloud NBT * Fix custom GUI fonts * Update beet and support 1.20.6 * Remove non-modules from build artifact * Substitute profile data in mcfunction files * Update biome extensions to 1.20.5 * Remove debug commands in cozy campfires * Fix poses pack and bookshelf book title * Allow module aliases in beet dev * Fix boots of ostara crafting * Fix washing tanks not clearing dyed_color component * Keep boots custom name when crafting boots of ostara * Fix soul glass has_beam predicate * Fix block compressors * Fix Tunnel Bores item drops * Fix tinkering compressors *this one was Misodes fault* And since we're retiring this in 1.21, I didn't do any efficiency refactors * Remove redundant tc check Actually we can make it little better without major refactors yay * Fix bookshelf inspectors * Fix: Liquid Minecart breaking, glow ink signs, floating potion advancement * Lightning in a bottle 1.20.5 (#997) * Fix brewing LiaB * Fix lib brewing custom potion predicate --------- Co-authored-by: Misode <misoloo64@gmail.com> * Refactor supported versions and releases in beet.yaml * Disable trouble modules * Minor version bump for all modules * Fix Relocators loot function (#999) * Update Balloon Animals to 1.20.5 (#998) - remove extra animal custom data value - remove modifier since the loot table can now copy just the expected value - Leash to leash - loot table reference name key is now value - animal type is now lead item name * Fix crossbow cartridges tnt fuse * Fix typo in record crafting * Update beet to use latest vanilla assets - fix turtle helmet disassembler issue - fix issues in guidebook and crafting plugins * Various fixes (moneo, standard crafting, teleportation anchors, dangerous dungeons) - fix moneo netherrite update (blame Epyon) - fix bamboo mosaic stairs decrafting (blame Special) - fix unused teleportation anchors destroy (blame BPR) - fix dangerous dungeons snowy tag (blame kruthers) - fix moneo tools tag (blame Misode) * Book Binders: 1.20.5 update (#1000) * Fix * Fixes dupe by removing foot stored enchants - Prevents duplicate enchant&level page from being absorbed - Updated run from comment that misode pointed out * Update mecha to 0.94.2 * Combat Expanded 1.20.5 (#996) * move tag storage to components * update identification loot tables * update identification loot tables * remove use of item_modifiers * honestly don't remember half of what this is... but updates? * fix up boss fight and final few modifiers * misode's review * change armor toughness vanilla UUID * Update mecha * Disable zauber and guidebook in tests * Switch to the ubuntu-24.04 beta runner * Fix mountaineering crafting recipe * Revert debug logging * Store block compressor old components in a new field and merge old tag with custom data * Remove tnt landmines * Remove trapped signs --------- Co-authored-by: SpecialBuilder <specialbuilder32@gmail.com> Co-authored-by: Epyon <66185010+EpyonProjects@users.noreply.github.com> Co-authored-by: Thanathor <73304324+TheThanathor@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
* Apply overlays * Update version numbers and pack format for 1.20.5 * Update all tests to 1.20.5 * Temporarily disable player heads plugins * Fix location predicates * Fix nested loot tables * Fix set lore mode field * Fix block/fluid/item predicates * Fix attribute operations * Potion contents item sub predicates * Enchantment item sub predicates * Advancement icons * Sweeping edge rename * Update yellow shulker box loot table * Fix set_nbt loot functions * Fix component issues with last commit - set_custom_data function only accepts stringified snbt - profile properties were incorrectly upgraded - written_book_content component had a typo * Upgrade custom model data substitutions * Fix advancement icon components * More set_nbt fixes * Misc errors * Replace horse jump strength attribute with max_stack_size=1 * Remove lib player heads, update skin cache plugin * Fix item predicate NBT field to sub predicates * Count -> count * scute -> turtle_scute * Fix remaining issues in loot table, recipe, advancements ignoring copy_nbt * Fix attribute operations in commands * Update mecha * Update copy_nbt in better armour stands, boots of ostara, chairs, and crossbow cartridges * Update copy_nbt in arborenda and mountaineering * Metallurgy item validity + update commands * Update item nbt checks in a few places + sunken treasure * Update lib trades, DecorItem -> body_armor_item * Lib trees * A bunch of tag -> components * Fix machine block placing * More tag -> components fixes + re-add b suffix in set_custom_data * Update mecha * Update particle syntax * Display frames + lightning in a bottle * Update to java 21 and 1.20.5-pre1 * Fix int providers no long wrapped in value field * Fix remaining particle commands * Update yellow shulker box loot table * Some balloon animals updates * Update packtest to 1.20.5 * Fix some errors in the tests * Even more tag -> components fixes * Final tag -> components fixes (except combat expanded) * Temporarily disable guidebook copy_nbt functions * Fix some leftover item nbt * biome -> biomes, structure -> structures, potion * Fix some more tests - amplifier:0b is not stored - add skyaccess to some tests - replace ambient_entity_effect * Combat expanded tag -> components fixes * Replace CMD in item components * Fix particles in area effect clouds * Replace some item_used_on_block with default_block_use * Fix a few more tests * Fix auto crafting item tag predicates * Random fixes (enchantment checks, phantom scarecrows, animi) * Fix area effect cloud NBT * Fix custom GUI fonts * Update beet and support 1.20.6 * Remove non-modules from build artifact * Substitute profile data in mcfunction files * Update biome extensions to 1.20.5 * Remove debug commands in cozy campfires * Fix poses pack and bookshelf book title * Allow module aliases in beet dev * Fix boots of ostara crafting * Fix washing tanks not clearing dyed_color component * Keep boots custom name when crafting boots of ostara * Fix soul glass has_beam predicate * Fix block compressors * Fix Tunnel Bores item drops * Fix tinkering compressors *this one was Misodes fault* And since we're retiring this in 1.21, I didn't do any efficiency refactors * Remove redundant tc check Actually we can make it little better without major refactors yay * Fix bookshelf inspectors * Fix: Liquid Minecart breaking, glow ink signs, floating potion advancement * Lightning in a bottle 1.20.5 (#997) * Fix brewing LiaB * Fix lib brewing custom potion predicate --------- Co-authored-by: Misode <misoloo64@gmail.com> * Refactor supported versions and releases in beet.yaml * Disable trouble modules * Minor version bump for all modules * Fix Relocators loot function (#999) * Update Balloon Animals to 1.20.5 (#998) - remove extra animal custom data value - remove modifier since the loot table can now copy just the expected value - Leash to leash - loot table reference name key is now value - animal type is now lead item name * Fix crossbow cartridges tnt fuse * Fix typo in record crafting * Update beet to use latest vanilla assets - fix turtle helmet disassembler issue - fix issues in guidebook and crafting plugins * Various fixes (moneo, standard crafting, teleportation anchors, dangerous dungeons) - fix moneo netherrite update (blame Epyon) - fix bamboo mosaic stairs decrafting (blame Special) - fix unused teleportation anchors destroy (blame BPR) - fix dangerous dungeons snowy tag (blame kruthers) - fix moneo tools tag (blame Misode) * Book Binders: 1.20.5 update (#1000) * Fix * Fixes dupe by removing foot stored enchants - Prevents duplicate enchant&level page from being absorbed - Updated run from comment that misode pointed out * Update mecha to 0.94.2 * Combat Expanded 1.20.5 (#996) * move tag storage to components * update identification loot tables * update identification loot tables * remove use of item_modifiers * honestly don't remember half of what this is... but updates? * fix up boss fight and final few modifiers * misode's review * change armor toughness vanilla UUID * Update mecha * Disable zauber and guidebook in tests * Switch to the ubuntu-24.04 beta runner * Fix mountaineering crafting recipe * Revert debug logging * Store block compressor old components in a new field and merge old tag with custom data * Remove tnt landmines * Remove trapped signs --------- Co-authored-by: SpecialBuilder <specialbuilder32@gmail.com> Co-authored-by: Epyon <66185010+EpyonProjects@users.noreply.github.com> Co-authored-by: Thanathor <73304324+TheThanathor@users.noreply.github.com>
SpecialBuilder32
added a commit
to SpecialBuilder32/GM4_Datapacks
that referenced
this pull request
Jul 9, 2024
* Apply overlays * Update version numbers and pack format for 1.20.5 * Update all tests to 1.20.5 * Temporarily disable player heads plugins * Fix location predicates * Fix nested loot tables * Fix set lore mode field * Fix block/fluid/item predicates * Fix attribute operations * Potion contents item sub predicates * Enchantment item sub predicates * Advancement icons * Sweeping edge rename * Update yellow shulker box loot table * Fix set_nbt loot functions * Fix component issues with last commit - set_custom_data function only accepts stringified snbt - profile properties were incorrectly upgraded - written_book_content component had a typo * Upgrade custom model data substitutions * Fix advancement icon components * More set_nbt fixes * Misc errors * Replace horse jump strength attribute with max_stack_size=1 * Remove lib player heads, update skin cache plugin * Fix item predicate NBT field to sub predicates * Count -> count * scute -> turtle_scute * Fix remaining issues in loot table, recipe, advancements ignoring copy_nbt * Fix attribute operations in commands * Update mecha * Update copy_nbt in better armour stands, boots of ostara, chairs, and crossbow cartridges * Update copy_nbt in arborenda and mountaineering * Metallurgy item validity + update commands * Update item nbt checks in a few places + sunken treasure * Update lib trades, DecorItem -> body_armor_item * Lib trees * A bunch of tag -> components * Fix machine block placing * More tag -> components fixes + re-add b suffix in set_custom_data * Update mecha * Update particle syntax * Display frames + lightning in a bottle * Update to java 21 and 1.20.5-pre1 * Fix int providers no long wrapped in value field * Fix remaining particle commands * Update yellow shulker box loot table * Some balloon animals updates * Update packtest to 1.20.5 * Fix some errors in the tests * Even more tag -> components fixes * Final tag -> components fixes (except combat expanded) * Temporarily disable guidebook copy_nbt functions * Fix some leftover item nbt * biome -> biomes, structure -> structures, potion * Fix some more tests - amplifier:0b is not stored - add skyaccess to some tests - replace ambient_entity_effect * Combat expanded tag -> components fixes * Replace CMD in item components * Fix particles in area effect clouds * Replace some item_used_on_block with default_block_use * Fix a few more tests * Fix auto crafting item tag predicates * Random fixes (enchantment checks, phantom scarecrows, animi) * Fix area effect cloud NBT * Fix custom GUI fonts * Update beet and support 1.20.6 * Remove non-modules from build artifact * Substitute profile data in mcfunction files * Update biome extensions to 1.20.5 * Remove debug commands in cozy campfires * Fix poses pack and bookshelf book title * Allow module aliases in beet dev * Fix boots of ostara crafting * Fix washing tanks not clearing dyed_color component * Keep boots custom name when crafting boots of ostara * Fix soul glass has_beam predicate * Fix block compressors * Fix Tunnel Bores item drops * Fix tinkering compressors *this one was Misodes fault* And since we're retiring this in 1.21, I didn't do any efficiency refactors * Remove redundant tc check Actually we can make it little better without major refactors yay * Fix bookshelf inspectors * Fix: Liquid Minecart breaking, glow ink signs, floating potion advancement * Lightning in a bottle 1.20.5 (Gamemode4Dev#997) * Fix brewing LiaB * Fix lib brewing custom potion predicate --------- Co-authored-by: Misode <misoloo64@gmail.com> * Refactor supported versions and releases in beet.yaml * Disable trouble modules * Minor version bump for all modules * Fix Relocators loot function (Gamemode4Dev#999) * Update Balloon Animals to 1.20.5 (Gamemode4Dev#998) - remove extra animal custom data value - remove modifier since the loot table can now copy just the expected value - Leash to leash - loot table reference name key is now value - animal type is now lead item name * Fix crossbow cartridges tnt fuse * Fix typo in record crafting * Update beet to use latest vanilla assets - fix turtle helmet disassembler issue - fix issues in guidebook and crafting plugins * Various fixes (moneo, standard crafting, teleportation anchors, dangerous dungeons) - fix moneo netherrite update (blame Epyon) - fix bamboo mosaic stairs decrafting (blame Special) - fix unused teleportation anchors destroy (blame BPR) - fix dangerous dungeons snowy tag (blame kruthers) - fix moneo tools tag (blame Misode) * Book Binders: 1.20.5 update (Gamemode4Dev#1000) * Fix * Fixes dupe by removing foot stored enchants - Prevents duplicate enchant&level page from being absorbed - Updated run from comment that misode pointed out * Update mecha to 0.94.2 * Combat Expanded 1.20.5 (Gamemode4Dev#996) * move tag storage to components * update identification loot tables * update identification loot tables * remove use of item_modifiers * honestly don't remember half of what this is... but updates? * fix up boss fight and final few modifiers * misode's review * change armor toughness vanilla UUID * Update mecha * Disable zauber and guidebook in tests * Switch to the ubuntu-24.04 beta runner * Fix mountaineering crafting recipe * Revert debug logging * Store block compressor old components in a new field and merge old tag with custom data * Remove tnt landmines * Remove trapped signs --------- Co-authored-by: SpecialBuilder <specialbuilder32@gmail.com> Co-authored-by: Epyon <66185010+EpyonProjects@users.noreply.github.com> Co-authored-by: Thanathor <73304324+TheThanathor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debinding uses a big loot table which will be generated with beet once they update the enchantments tag.
New unavoidable "bug": Adding a page with a repeat enchantment will delete the previous level