Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Bugfix: Github Actions runner permission fails at multiple runs #60

Closed
7 tasks done
madebyTimo opened this issue Jun 27, 2022 · 4 comments
Closed
7 tasks done
Assignees
Labels
bug Something isn't working storypoint/3 3 Storypoints (12 man hours)

Comments

@madebyTimo
Copy link

madebyTimo commented Jun 27, 2022

Current Behavior

After one run the CI fails in the next run because it can't remove files created by the last run. exapmle failure
The actual solution is to run a cleanup task at the end of every run like you can see here

Expected Behavior

Runs don't fail because they already run once and the folder isn't deleted manually (or by a cleanup task).

DoD

If there is a solution:

  • runs don't fail because they already run once
  • CI-caching works
  • no actual CI fails cause of the described error

If there is no solution:

  • related Github Action Issues are checked and documented
  • cleanup task is added to all actual CIs
  • need of cleanup task is announced to project members
  • no actual CI fails cause of the described error
@madebyTimo madebyTimo added the bug Something isn't working label Jun 27, 2022
@madebyTimo madebyTimo changed the title Github Actions runner permission issues at multiple runs Github Actions runner permission failes at multiple runs Jun 27, 2022
@madebyTimo madebyTimo changed the title Github Actions runner permission failes at multiple runs Github Actions runner permission fails at multiple runs Jun 27, 2022
@delvh delvh added the storypoint/2 2 Storypoints (8 man hours) label Jun 28, 2022
@madebyTimo madebyTimo self-assigned this Jun 30, 2022
@madebyTimo madebyTimo added storypoint/3 3 Storypoints (12 man hours) and removed storypoint/2 2 Storypoints (8 man hours) labels Jun 30, 2022
@madebyTimo
Copy link
Author

Also problems at login backend

@madebyTimo
Copy link
Author

It is a general problem with Github-Actions. Related issues can be found amount many other issues here and there.

As workaround we decided to run the runner as root, so it has all permission. This shouldn't be a problem because jobs are only triggered by team-members and the runner runs on a dedicated VM.

@delvh
Copy link
Contributor

delvh commented Jul 3, 2022

While I am typically not in favor of running programs as root, I can at least understand it in this case.
Should we inform Professor Becker about this?

@madebyTimo
Copy link
Author

I don't think we need to do this. It's a dedicated VM only for the runner and the old user also had docker rights which lead to nearly same permissions as root permission

@marlau97 marlau97 changed the title Github Actions runner permission fails at multiple runs Maintenance Bugfix: Github Actions runner permission fails at multiple runs Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working storypoint/3 3 Storypoints (12 man hours)
Projects
Status: Stupro
Development

No branches or pull requests

3 participants