Juggler: Reduced memory allocations by removing the Dictionary implementation for object ids #1099
+49
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent many String allocations
Changes
_objectIDs
is now aVector.<uint>
containing the objects' idsremoveByIndex
methodobject in _objectIDs
have been replaced bycontains(object)
advanceTime
method) logic has been updated accordinglyThis PR needs further testing. Changes are working on my side but I'm not sure I have covered all cases.