Performance #19
Performance #19
Conversation
This allows marking simple resolve functions as ones that should always avoid extra go routines
executor.go
Outdated
| @@ -33,7 +33,7 @@ func Execute(p ExecuteParams) (result *Result) { | |||
| ctx = context.Background() | |||
| } | |||
| if p.manager == nil { | |||
| p.manager = manager | |||
There was a problem hiding this comment.
This is messing with my mind -- where did this old value even come from that it worked?
There was a problem hiding this comment.
Whoops I thought I was fixing this for a test, I shouldn't have made that change in the main executor. I'm glad you pointed it out. To answer your question though it comes from https://github.com/GannettDigital/graphql/blob/master/graphql.go
There was a problem hiding this comment.
Ahh, the var ( being on a different line defeated my git grep-Fu by looking like a function use.
| @@ -1041,7 +1045,7 @@ func TestNonNull_NullsTheTopLevelIfSyncNonNullableFieldErrors(t *testing.T) { | |||
| query Q { nonNullPromise } | |||
| ` | |||
| expected := &graphql.Result{ | |||
| Data: map[string]interface{}{"nonNullPromise": nil}, | |||
| Data: nil, | |||
There was a problem hiding this comment.
Interesting that this changes the resulting data... hopefully that won't be an issue, since this only occurs on an error anyway.
|
Biggest downside to this change is that both |
No description provided.