ISSUE-9 - fixed flow control and added a test to confirm

GannettDigital · Jun 29, 2016 · 8dc2a59 · 8dc2a59
1 parent 9575865
commit 8dc2a59
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/concurrent.js b/lib/concurrent.js
@@ -5,6 +5,7 @@ module.exports = Concurrent = {
     concurrent: function(functions, callback) {
         if (functions.length === 0) {
             process.nextTick(callback.bind(null, null, []));
+            return;
         }
 
         var state = {

diff --git a/test/unit/concurrent.js b/test/unit/concurrent.js
@@ -99,15 +99,19 @@ describe('concurrent - unit tests', function() {
 
     describe('concurrent - entry point - empty input', function() {
         var tasks = [];
+        var forEachStub;
         before(function() {
             mapConcurrentCallbackBindStub = sinon.stub(Concurrent._concurrentCallback, 'bind').returns(boundConcurrentCallback);
+            forEachStub = sinon.stub(Array.prototype, 'forEach');
         });
 
         after(function() {
             Concurrent._concurrentCallback.bind.restore();
+            Array.prototype.forEach.restore();
         });
 
         beforeEach(function() {
+            forEachStub.reset();
             mapConcurrentCallbackBindStub.reset();
             Concurrent.concurrent(tasks, callbackSpy);
         });
@@ -127,6 +131,10 @@ describe('concurrent - unit tests', function() {
                boundCallbackSpy
             ]);
         });
+
+        it('should not call forEach when the input is an empty array', function() {
+            expect(forEachStub.callCount).to.equal(0);
+        });
     });
 
     describe('concurrent - callback', function() {