Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all initializer list ordering #1150

Closed
crabmusket opened this issue Feb 2, 2015 · 3 comments
Closed

Fix all initializer list ordering #1150

crabmusket opened this issue Feb 2, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@crabmusket
Copy link
Contributor

There are a ton of warnings generated by gcc's -Wreorder. The warning's meaning is explained here. Might not be any actual bugs, but it'd be nice to be on the safe side.

@crabmusket crabmusket changed the title Fix all initializer list order Fix all initializer list ordering Feb 2, 2015
@crabmusket crabmusket added this to the 3.8 milestone Feb 22, 2015
@crabmusket crabmusket self-assigned this Feb 22, 2015
@raistlin
Copy link
Contributor

raistlin commented Jul 3, 2015

I have seen that there are a lot of -Wreorder warnings generated inside /lib/ files.
I think that is not a good idea to modify this files directly, because they will be overwritten if we update these libraries in future.

What do you think?

@dottools
Copy link

dottools commented Jul 3, 2015

Yeah, third party libraries shouldn't be modified unless absolutely necessary to integrate with the engine that otherwise wouldn't be useable.

@crabmusket
Copy link
Contributor Author

What @dottools said. I've mentioned before the possibility of using git submodules for our lib dependencies, at least those of them for which that's feasible - in that case maybe we could contribute back to those dependencies, maybe fix some warnings, etc. But that might not be a realistic ideal :p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants