Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved gitignore for VS2012 #578

Merged
merged 1 commit into from
Mar 16, 2014
Merged

improved gitignore for VS2012 #578

merged 1 commit into from
Mar 16, 2014

Conversation

tdev
Copy link

@tdev tdev commented Mar 14, 2014

No description provided.

@crabmusket
Copy link
Contributor

I approve.

@dottools
Copy link

I don't see why these ignores are even necessary since the very files you're trying to ignore should already reside under My Projects/ directory which is already ignored.

@crabmusket
Copy link
Contributor

That is a very good point actually, thanks Nathan.

@tdev
Copy link
Author

tdev commented Mar 15, 2014

I don't see why these ignores are even necessary since the very files you're trying to ignore should already reside under My Projects/ directory which is already ignored.

i don't make things up. Try to run generateAllProjects.bat

@crabmusket
Copy link
Contributor

@tdev, are you generating projects in the templates?

@tdev
Copy link
Author

tdev commented Mar 15, 2014

@tdev, are you generating projects in the templates?

yes, i don't want to start the project generator gui for these things

anyways, i don't see a problem with this PR being merged.

@crabmusket
Copy link
Contributor

Right. The templates obviously aren't supposed to have projects generated in them. But hey, I do that as well for the same reason. So I also have no problem with this.

@LuisAntonRebollo
Copy link
Contributor

It does not cause any damage and prevents any pull request mistakenly add some unwanted files.

I approve.

LuisAntonRebollo added a commit that referenced this pull request Mar 16, 2014
improved gitignore for VS2012
@LuisAntonRebollo LuisAntonRebollo merged commit 6dfaf33 into GarageGames:development Mar 16, 2014
@tdev tdev deleted the gitignore branch March 18, 2014 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants