Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added impersonation support #2

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Added impersonation support #2

merged 1 commit into from
Aug 19, 2015

Conversation

eldiddio
Copy link

Included extra type classes and class mappings for extra fields required for impersonation.

Garethp added a commit that referenced this pull request Aug 19, 2015
Added impersonation support
@Garethp Garethp merged commit f463202 into Garethp:master Aug 19, 2015
@Garethp
Copy link
Owner

Garethp commented Aug 19, 2015

Thanks. FYI: I'm not sure how much of this will be overwritten by the class generation I'm writing for objects in one of my branches. I'll make sure impersonation still works on my next version release though

@Garethp
Copy link
Owner

Garethp commented Aug 20, 2015

Hi, I've had to undo some of your work in the latest merge for a couple of reasons:

  • Objects are now auto-generated, as is the classMap, so I've had to undo your objects and their mappings, but they should exist now any way
  • FolderId's and ItemId's now exist as objects, and get returned as such, so I've had to undo your getFolderIdsArray() things. Sorry about that, but I'm planning on keeping them as objects for now
  • I noticed in your getFolderIdsArray() part, the option was either to use impersonation or DistinguisedId. That breaks a bit. For example, if you want to use a calendar folder without impersonating, that wouldn't work any more

I hope you understand. As it stands, this new merge is massive and breaking, but it's a huge step forward. Once I fix my tests I'll be marking it as a new version and then I'll look in to getting impersonation working in a better way

Thanks, Gareth

@Garethp
Copy link
Owner

Garethp commented Aug 24, 2015

Hi

Previously impersonation was supported through the $options section of buildClient(), but you needed to build the object yourself. I've changed that now. Now you can just pass in an email address when building the client and it'll build the object for you. Take a look here for an example. Also, if you want to build an ExchangeImpersonation object from an email yourself, there now exists an ExchangeImpersonation::fromEmail($email) method that will do it for you.

I hope this suits your needs. If it doesn't, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants