Change Linux font path if required #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense to do the detection in code, not in CMAKE? |
|
Indeed, it is probably more coherent to make the detection code in the main file |
|
@Gargaj ok, I have transfered the font choice from the cmake to the executable. I can still modify it if it does not fit your coding standards |
|
Is there no way to do it without that #include-pyramid at the start? Also, why is the 64-bit build excluded? |
|
I've removed all the ifdef stuff ; I guess I excluded 64bits after misinterpreting error messages generated by the continuous integration tools |
|
Looks good now thanks (shame about the extra whitespace but I'd be awfully pedantic if I'd force you to change that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Linux, Bonzomatic wants to use the following font
/usr/share/fonts/corefonts/cour.ttf.It seems its installation path depends in not stable over distributions/versions.
This patch use the font
/usr/share/fonts/truetype/msttcorefonts/cour.ttfif the initial one does not exist