Added test for batch operations

.travis.yml

@@ -1,4 +1,4 @@
 language: node_js
 node_js:
   - "10"
-after_success: npm run coverage
+after_success: npm run report-coverage

jsondown.js

@@ -2,7 +2,7 @@ const AbstractLevelDOWN = require("abstract-leveldown").AbstractLevelDOWN;
 const os = require("os");
 const util = require("util");
 const path = require("path");
-const mkdirp = require("mkdirp");
+const makeDir = require("make-dir");
 const MemDOWN = require("memdown");
 const fs = require("fs");
 
@@ -15,9 +15,6 @@ function serializeStore(store) {
 }
 
 function jsonToBatchOps(data) {
-  if (!data) {
-    throw new Error();
-  }
   return Object.keys(data).map(function (key) {
     var value = data[key];
     if (typeof value !== "string") {
@@ -55,7 +52,6 @@ function reviver(k, v) {
 function noop() {}
 
 function JsonDOWN(location) {
-  if (!(this instanceof JsonDOWN)) return new JsonDOWN(location);
   AbstractLevelDOWN.call(this);
   MemDOWN.call(this);
   this.location = location;
@@ -77,7 +73,7 @@ JsonDOWN.prototype._open = function (options, callback) {
       ? this.location.split(path.sep).slice(0, -1).join(path.sep)
       : this.location;
 
-  mkdirp(subdir)
+  makeDir(subdir)
     .then((made) => {
       fs.exists(loc, function (exists) {
         if (!exists && options.createIfMissing === false) {
@@ -120,7 +116,9 @@ JsonDOWN.prototype._open = function (options, callback) {
         }
       });
     })
-    .catch((errMkdirp) => callback(errMkdirp));
+    .catch((err) => {
+      callback(err);
+    });
 };
 
 JsonDOWN.prototype._close = function (cb) {

package.json

@@ -23,12 +23,14 @@
     "abstract-leveldown": "^6.3.0",
     "coveralls": "^3.1.0",
     "levelup": "^4.4.0",
+    "make-dir": "^3.1.0",
     "nyc": "^15.1.0",
     "tape": "^5.0.1",
     "tempy": "^0.5.0"
   },
   "scripts": {
-    "coverage": "nyc report --reporter=text-lcov --reporter=html | coveralls",
+    "coverage": "nyc report --reporter=text-lcov --reporter=html",
+    "report-coverage": "npm coverage | coveralls",
     "test": "nyc tape test/jsondown.test.js"
   },
   "homepage": "https://github.com/toolness/jsondown",

test/jsondown.test.js

@@ -2,6 +2,7 @@ const test = require("tape");
 const suite = require("abstract-leveldown/test");
 const JsonDOWN = require("../jsondown");
 const tempy = require("tempy");
+const path = require("path");
 
 const testCommon = suite.common({
   test,
@@ -44,20 +45,39 @@ test("malformed JSON should return an error", (t) => {
     });
 });
 
+test("bad location path should returns an error", (t) => {
+  const db = testCommon.factory();
+  db.location = path.join(db.location, "foo\u0000bar");
+  db.open((err) => {
+    t.match(
+      err.toString(),
+      new RegExp(
+        `The argument 'path' must be a string or Uint8Array without null bytes. Received`,
+        "g"
+      ),
+      "bad path returns an error"
+    );
+    t.end();
+  });
+});
+
+test("batchOps with values", (t) => {
+  const db = testCommon.factory();
+  db.open(function (err) {
+    t.error(err);
+    db.put("foo", "bar", (err) => {
+      t.error(err);
+      db.close((err) => {
+        t.error(err);
+        db.open((err) => {
+          t.error(err);
+          db.close(() => {
+            t.end();
+          });
+        });
+      });
+    });
+  });
+});
+
 test("tearDown", testCommon.tearDown);
-//
-// test('test simple put()', function (t) {
-//
-//   db.put('foo', 'bar', function (err) {
-//     t.error(err)
-//     db.get('foo', function (err, value) {
-//       t.error(err)
-//       var result = value.toString()
-//       if (isTypedArray(value)) {
-//         result = String.fromCharCode.apply(null, new Uint16Array(value))
-//       }
-//       t.equal(result, 'bar')
-//       t.end()
-//     })
-//   })
-// })