Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error for consuming apps, caused by (set) helper #79

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

roomman
Copy link

@roomman roomman commented Sep 7, 2021

My consuming app was throwing the following error, using this addon with the <Transition> component:

Build Error (PackagerRunner) in node_modules/ember-headlessui/components/transition.hbs

Module Error (from .../node_modules/thread-loader/dist/cjs.js):
Missing helper: set in node_modules/ember-headlessui/components/transition.hbs

This PR fixes the issue by moving the set helper module into the package dependencies.

It also upgrades from the deprecated ember-simple-set-helper to ember-set-helper, and includes the required refactoring.

All tests are passing.

@roomman roomman marked this pull request as ready for review September 7, 2021 15:05
Copy link
Collaborator

@alexlafroscia alexlafroscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome; thanks for making this PR!

I had noticed over the weekend that this package was using ember-simple-set-helper but didn't realize that it was used inside the addon tree and not actually set as a dependency. I really appreciate the clean-up here!

@alexlafroscia alexlafroscia added the bug Something isn't working label Sep 7, 2021
@alexlafroscia
Copy link
Collaborator

CI doesn't run until approved for first-time contributors, but I just kicked it off. Once it's passing I'll merge and cut a release with this fix!

@alexlafroscia alexlafroscia merged commit 139bcf5 into GavinJoyce:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants