108 contact examples and fixes #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armantekinalp
added
bug
Codecov Report
@@ Coverage Diff @@
## update-0.2.4 #109 +/- ##
===============================================
Coverage ? 87.09%
===============================================
Files ? 40
Lines ? 2534
Branches ? 343
===============================================
Hits ? 2207
Misses ? 305
Partials ? 22 Continue to review full report at Codecov.
|
skim0119
requested changes
Jun 11, 2022
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_with_y_normal.py
Outdated
Show resolved
Hide resolved
|
Flags capitalized and post-processing scripts are moved to |
pppprub
pushed a commit
to pppprub/PyElastica
that referenced
this pull request
Sep 4, 2022
**Update** * We decided to have `numba` as our core dependency, and drop numpy-only version. * Update merge existing `numpy` functions into `elastica` module. If `numba` implementation exist, `numba` version is merged and existing `numpy` version is discarded. * Left `_elastica_numba` module and references, but throws deprecation warning if one tries to load. * `_elastica_numpy` module throws deprecation warning. * Impacted test cases are modified. **Module** * boundary condition * external_forces * external_forces * interaction * joint * reset_ghost_vector_or_scalar * rotation * rod * timestepper **Modified** * remove Numpy code for Muscular flagella This commit removes Numpy code for connections and forcing for muscular flagella, and renames the Numba code as `connection_flagella.py` and `muscle_forces_flagella.py` . * typo in muscular flagella connections fixed This commit fixes the typo in `MuscularFlagellaConnection` class. * fix numpy-int depreciate warning This commit changes np.int to np.int64 and np.complex to np.complex128 in `memory_block_rod.py` and `analytical.py` . Since Numpy will depreciate them in future releases. Co-authored-by: Seung Hyun Kim <skim449@illinois.edu> Co-authored-by: Bhosale <bhosale2@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108 and also we added example cases for rod-cylinder contact.