-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
108 contact examples and fixes #109
108 contact examples and fixes #109
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.2.4 #109 +/- ##
===============================================
Coverage ? 87.09%
===============================================
Files ? 40
Lines ? 2534
Branches ? 343
===============================================
Hits ? 2207
Misses ? 305
Partials ? 22 Continue to review full report at Codecov.
|
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_validation.py
Outdated
Show resolved
Hide resolved
examples/RigidBodyCases/RodRigidBodyContact/rod_cylinder_contact_with_y_normal.py
Outdated
Show resolved
Hide resolved
Flags capitalized and post-processing scripts are moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**Update** * We decided to have `numba` as our core dependency, and drop numpy-only version. * Update merge existing `numpy` functions into `elastica` module. If `numba` implementation exist, `numba` version is merged and existing `numpy` version is discarded. * Left `_elastica_numba` module and references, but throws deprecation warning if one tries to load. * `_elastica_numpy` module throws deprecation warning. * Impacted test cases are modified. **Module** * boundary condition * external_forces * external_forces * interaction * joint * reset_ghost_vector_or_scalar * rotation * rod * timestepper **Modified** * remove Numpy code for Muscular flagella This commit removes Numpy code for connections and forcing for muscular flagella, and renames the Numba code as `connection_flagella.py` and `muscle_forces_flagella.py` . * typo in muscular flagella connections fixed This commit fixes the typo in `MuscularFlagellaConnection` class. * fix numpy-int depreciate warning This commit changes np.int to np.int64 and np.complex to np.complex128 in `memory_block_rod.py` and `analytical.py` . Since Numpy will depreciate them in future releases. Co-authored-by: Seung Hyun Kim <skim449@illinois.edu> Co-authored-by: Bhosale <bhosale2@illinois.edu>
Fixes #108 and also we added example cases for rod-cylinder contact.