-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrades #28
Conversation
Also fixes the example.
I think that somehow broke something. My test machine logs everything with |
Okay, I could fix the problem. It was not my fault, it was already present. We should create some tests to cover all this. |
IIRC Both I'm all for upgrading the dependencies, but it would be nice to be able to discuss and fix the bugfix separately from this main change. |
Yeah, I know that |
5ed3909
to
a5c5d3d
Compare
Hello,
Thank you for taking care of this.
First things first: please keep the changes minimal, avoid cosmetic changes
and reindentation. I'd be willing to merge it but I do not have the time to
check all the indentation changes and see if something else changed.
The fixes to kern_emerg and format! usage can go in other pull requests
On Feb 28, 2018 09:31, "Bastian Köcher" <notifications@github.com> wrote:
Yeah, I know that format! and write! should go almost the same path. The
only difference I can imagine is that write! writes byte by byte or
something similar and the syslog implementation reads it byte by byte. On
my test machine I saw that each log message got split across several log
messages.
I can create a different pull request, just with "the fix"/hack in it. I'm
open to a better solution, but currently I don't have any :/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHSAAz9_3cwD4_E163xYimQQVbodEKpks5tZQ7VgaJpZM4STU1I>
.
|
@Geal yeah, I already created a new pull request. And yeah, I run rustfmt, but I created a separate commit for this, so the real changes can be seen easily. |
This PR also fixes #32. |
@Geal any chance that this could be merged? |
Hello, I merged all the commits except the rustfmt one. I'll see if I can make a format pass before the release. |
Fixes: #27