Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language selector #129

Closed
XaviTorello opened this issue Oct 26, 2020 · 1 comment · Fixed by #137
Closed

Add language selector #129

XaviTorello opened this issue Oct 26, 2020 · 1 comment · Fixed by #137
Assignees
@francescarpi
Labels
backend Dev team enhancement New feature or request
Milestone
sprint 4

Comments

@XaviTorello
Copy link

Is your feature request related to a problem? Please describe.
Related to #11, we need a way to define current session language.

Describe the solution you'd like
A combo with all available languages will be ideal.

Also think if registered users should store and reuse their language.
@XaviTorello XaviTorello added the enhancement New feature or request label Oct 26, 2020
@XaviTorello
Copy link
Author

Maybe it's better to just provide a combo to change session language for now :)

@francescarpi francescarpi added the backend Dev team label Oct 27, 2020
@francescarpi francescarpi added this to the sprint 4 milestone Oct 27, 2020
@francescarpi francescarpi self-assigned this Oct 28, 2020
francescarpi pushed a commit that referenced this issue Oct 28, 2020
(#129) [New]: Language selector and template literals translated
5abbb9c
@francescarpi francescarpi mentioned this issue Oct 28, 2020
Merged
francescarpi pushed a commit that referenced this issue Oct 28, 2020
(#129) [New]: Pre commit executed
58a51f1
francescarpi pushed a commit that referenced this issue Oct 28, 2020
(#129) [New]: Lang selector added in template and po files regenerated
3f3b9a1
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [Fixes]: Sonarcloud fixes
45dbd5b
@francescarpi francescarpi mentioned this issue Oct 29, 2020
Closed
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [Fixes]: Sonarcloud fixes
30b6521
@francescarpi francescarpi mentioned this issue Oct 29, 2020
Closed
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [New]: Language selector and template literals translated
8ed3583
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [New]: Language selector and template literals translated
f69a237
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [Fixed]: Make messages without locale and env for define defau…
c197ce1 
…lt lang
francescarpi pushed a commit that referenced this issue Oct 29, 2020
(#129) [Fixed]: Make messages without locale and env for define defau…
7fb97a3 
…lt lang
francescarpi added a commit that referenced this issue Oct 30, 2020
@francescarpi
Merge pull request #137 from GeeksCAT/_129_lang_selection
f97cf35 
(#129) [New]: Language selector and template literals translated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francescarpi francescarpi

Labels
backend Dev team enhancement New feature or request
Projects
None yet
Milestone
sprint 4
Development

Successfully merging a pull request may close this issue.

(#129) [New]: Language selector and template literals translated GeeksCAT/nem-per-feina
2 participants
@francescarpi @XaviTorello