Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use zipWriter.SetOffset instead of "zip -A" #87

Merged
merged 5 commits into from
Apr 12, 2017

Conversation

boyvinall
Copy link
Contributor

addresses #74

@boyvinall
Copy link
Contributor Author

I'm not sure why lint failed on https://app.wercker.com/buildstep/58359a0511125f0100d850a1. I'm not familiar with wercker .. doing read of the docs, I thought I could use a docker image as the "box". I built using the wercker CLI tool using this updated wercker.yml but that seems to fail on their cloud environment.

The reason for this PR was I hit an issue with zip -A when trying to run on a vagrant/virtualbox shared host filesystem, it looked like there was some filesystem sync issue. My change seems to help with this... and it also closed one of your issues.

Grateful for any advice you can offer in getting the wercker build running, otherwise I might not get back to this for a while.

@GeertJohan GeertJohan merged commit 867f191 into GeertJohan:master Apr 12, 2017
@GeertJohan
Copy link
Owner

Thanks!

This was referenced Apr 12, 2017
@boyvinall
Copy link
Contributor Author

Glad to help, thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants